explicitly install needed build tools rather than installing build-essential#86
explicitly install needed build tools rather than installing build-essential#86mikaelarguedas wants to merge 1 commit intomasterfrom
Conversation
…essential Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
|
What is console_bridge using pkg-config for originally? |
|
As far as I can tell it's not used by the package. my guess is that it was added by the debian maintainers because the package provides a This should not impact this PR much though |
|
Looks like we only save two or three megabytes. Won't we also have to parameterize the libc version based on what distro the template is applied to, rather than hard-coding it to 6? How much more worth while would this be if we were able to prune pkg-config downstream in ros? |
Yeah the value of it is more by being explicit on what we want installed than saving space, I also roped in cmake that was not explicitly installed before this PR (though always pulled in).
It's hard to say given that it's brought in by such low level packages so we dont know how many of pkg-config dependencies will be installed by other packages. I originally thought we could save up to 50MB but that was before I realized
This is just the name used for glibc in debian. I don't think it changed in the last 20 years and don't know (though didnt look much) of any plan to change it in the near future, so I wouldnt see this one as a concern. |
2 participants
Based on feedback from docker-library/official-images#8031 (comment)
Impact on current images:
For all ubuntu images -> no impact as
pkg-configdepends ondpkg-devon xenial and bionicFor debian stretch images:
For future images -> expected impact is minor as ROS 1 and ROS 2 rely on libconsole-bridge-dev that depends on pkg-config.
It should be safe to do this change, it will have the advantage of being explicit on the packages we expect people to need for building packages.
We could potentially significant space in the future by requesting console_bridge to make the dependency on pkg-config optional.